Skip to content

chore: remove @iconify-json/solar#899

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:no-solar
Feb 4, 2026
Merged

chore: remove @iconify-json/solar#899
danielroe merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:no-solar

Conversation

@wojtekmaj
Copy link
Contributor

We used barely two icons from this set, pulling in additional 6.5 MB dependency. This PR replaces solar icons: shield-check and eye-scan, with lucide icons: shield-check and view, respectively. They are virtually the same.

We used barely two icons from this set, pulling in additional 6.5 MB dependency. This PR replaces solar icons: shield-check and eye-scan, with lucide icons: shield-check and view, respectively. They are virtually the same.
Copilot AI review requested due to automatic review settings February 4, 2026 00:11
@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Error Error Feb 4, 2026 0:12am
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 0:12am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 4, 2026 0:12am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The changes involve a migration from Solar icons to Lucide icons across multiple files. The ProvenanceBadge component and the package page component have their icon classes updated from Solar naming conventions to Lucide equivalents. Specifically, i-solar-shield-check-outline becomes i-lucide-shield-check and i-solar:eye-scan-outline becomes i-lucide-view. The package.json file has the @iconify-json/solar dependency removed from the dependencies list. No logic or control-flow changes are present in these modifications.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the rationale for removing the @iconify-json/solar dependency (6.5 MB for only two icons) and identifies the specific icon replacements from lucide.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the @iconify-json/solar dependency (6.5 MB) and replaces the two solar icons used in the codebase with equivalent lucide icons, which is already an established dependency.

Changes:

  • Removed @iconify-json/solar from package.json and pnpm-lock.yaml
  • Replaced shield-check-outline solar icon with shield-check lucide icon in provenance badges and package pages
  • Replaced eye-scan-outline solar icon with view lucide icon for the dependency tree inspection link

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Removed @iconify-json/solar dependency
pnpm-lock.yaml Removed all solar icon package references and snapshots
app/components/ProvenanceBadge.vue Updated icon class from i-solar-shield-check-outline to i-lucide-shield-check
app/pages/package/[...package].vue Updated shield-check and eye-scan icons to lucide equivalents
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/pages/package/[...package].vue 0.00% 2 Missing ⚠️
app/components/ProvenanceBadge.vue 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2026
@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit 1448d26 Feb 4, 2026
20 of 23 checks passed
@wojtekmaj wojtekmaj deleted the no-solar branch February 4, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants