chore: remove @iconify-json/solar#899
Conversation
We used barely two icons from this set, pulling in additional 6.5 MB dependency. This PR replaces solar icons: shield-check and eye-scan, with lucide icons: shield-check and view, respectively. They are virtually the same.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
📝 WalkthroughWalkthroughThe changes involve a migration from Solar icons to Lucide icons across multiple files. The ProvenanceBadge component and the package page component have their icon classes updated from Solar naming conventions to Lucide equivalents. Specifically, 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the @iconify-json/solar dependency (6.5 MB) and replaces the two solar icons used in the codebase with equivalent lucide icons, which is already an established dependency.
Changes:
- Removed
@iconify-json/solarfrom package.json and pnpm-lock.yaml - Replaced
shield-check-outlinesolar icon withshield-checklucide icon in provenance badges and package pages - Replaced
eye-scan-outlinesolar icon withviewlucide icon for the dependency tree inspection link
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removed @iconify-json/solar dependency |
| pnpm-lock.yaml | Removed all solar icon package references and snapshots |
| app/components/ProvenanceBadge.vue | Updated icon class from i-solar-shield-check-outline to i-lucide-shield-check |
| app/pages/package/[...package].vue | Updated shield-check and eye-scan icons to lucide equivalents |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
We used barely two icons from this set, pulling in additional 6.5 MB dependency. This PR replaces solar icons: shield-check and eye-scan, with lucide icons: shield-check and view, respectively. They are virtually the same.