Survive remote connection failures in the bridge accept loop - #53
Merged
Conversation
Test-driving the bridge with a wrong --token showed a connecting client hanging forever: the failed WebSocket handshake threw inside the accept loop, killing it silently and leaving the local socket open, with all subsequent connections ignored. Now a failed relay setup closes the client socket immediately (the client errors out instead of hanging), logs the cause to stderr, and the bridge keeps accepting. The remote side is opened before any local transport resources so a failure has nothing to leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-driving the merged bridge end to end surfaced a bad failure mode: point the bridge at an endpoint that rejects it (e.g. a wrong
--token) and a connecting editor hangs forever with no error, while the failed handshake silently kills the accept loop, so the bridge never serves another connection.Now a failed relay setup closes the client socket right away (the client errors out immediately), the cause lands on the bridge's stderr, and the accept loop keeps going. Verified live against a token-guarded WebSocket endpoint: two consecutive client attempts both fail fast and the bridge stays up.