feat(core): merge target configurations from plugin results#19935
Merged
AgentEnder merged 1 commit intonrwl:masterfrom Oct 31, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ae6688. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/merge-target-configurations-from-plugins
branch
3 times, most recently
from
5133b06 to
5b4c7c7
Compare
FrozenPandaz
approved these changes
Oct 30, 2023
AgentEnder
force-pushed
the
feat/merge-target-configurations-from-plugins
branch
from
5b4c7c7 to
8ae6688
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
If multiple plugins identify the same target on the same project, whichever plugin identified the target last "wins", in that it completely overwrites the already present target.
Since
project.jsonis implemented as a plugin, this means the configuration insideproject.jsonoverwrites the full target block that was identified by any plugin.Expected Behavior
If the already identified target, and the newly found target are "compatible (either only 1 specifies executor, or the executor matches), then we can merge the target configurations.
This enables overwriting 1 or 2 properties in the
project.json, while inference takes care of the rest.Related Issue(s)
Fixes #