fix(core): align createNodesFromFiles options type with createNodes callback#30332
Closed
RobbyRabbitman wants to merge 1 commit intonrwl:masterfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
FrozenPandaz
added
the
priority: medium
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
type of
optionfromcreateNodes()callback does not match type ofoptionofcreateNodesFromFiles. Change was introduced in 20.5.0 by #29935.A workaround in 20.5.0 is to get a type by using
Parameters<typeof createNodesFromFiles<MyOptions>>[0]. Before 20.5.0 you could useCreateNodesFunction<MyOptions>when you wanted to type your createNodes function. Of course you could pass an arrow function, but I think many plugin authors use a separate function.Expected Behavior
They should have the same types or there should be a public type of the
createNodes()callback, so that users have better dx.Related Issue(s)
Fixes #