Skip to content

Comments

fix(nx/js): support's bun text lock file in nx release#30389

Closed
patlux wants to merge 1 commit intonrwl:masterfrom
patlux:bugfix/bun-lock-text-file
Closed

fix(nx/js): support's bun text lock file in nx release#30389
patlux wants to merge 1 commit intonrwl:masterfrom
patlux:bugfix/bun-lock-text-file

Conversation

@patlux
Copy link

@patlux patlux commented Mar 15, 2025

This PR fixes an error when running nx release:

Current Behavior

 NX   Updating bun lock file


 NX   Staging changed files with git


 NX   fatal: pathspec 'bun.lockb' did not match any files

Expected Behavior

 NX   Updating bun lock file


 NX   Staging changed files with git

Related Issue(s)

#30064

@patlux patlux requested review from a team and meeroslav as code owners March 15, 2025 19:47
@patlux patlux requested a review from AgentEnder March 15, 2025 19:47
@vercel
Copy link

vercel bot commented Mar 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2025 7:52pm

@patlux patlux force-pushed the bugfix/bun-lock-text-file branch from 5c0abeb to bfc9973 Compare March 15, 2025 19:48
// In version 1.2.0, bun switched to a text based lockfile format by default
return gte(bunVersion, '1.2.0');
} catch {
return false;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure which is the better default setting.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In versions above 1.2.0 you can still tell bun to use old format. Probably would make more sense to just look for either file

@patlux patlux changed the title support's bun text lock file in nx release fix(nx/js): support's bun text lock file in nx release Mar 16, 2025
@FrozenPandaz FrozenPandaz added the priority: medium Medium Priority (not high, not low priority) label May 14, 2025
@JamesHenry
Copy link
Collaborator

Sorry for the delay on this one @patlux, we have a more holistic fix here #31973 so closing in favour of that one

I have personally started to use bun more and really liking it, so we are working hard to make sure the support in Nx is as good as it can be

@JamesHenry JamesHenry closed this Jul 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

priority: medium Medium Priority (not high, not low priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants