fix(build): nginx validation false-fails on pid-file permission (golden-path step 4) - #188
Merged
Merged
Conversation
…uirement - sdk/ts/package.json repository.url pointed at nonexistent nself-org/plugin-sdk-ts, causing npm sigstore provenance verification to fail (422) against the actual nself-org/cli publishing repo. - sdk-ts-sdk-publish.yml pinned pnpm to 'latest' (11.9.0), which requires Node >=22.13 and crashed on the workflow's Node 20 runtime (ERR_UNKNOWN_BUILTIN_MODULE: node:sqlite). Pinned to 9, matching the sibling sdk-ts-publish.yml workflow.
…e exit nself build post-build validation ran 'nginx -t' and treated ANY non-zero exit as a syntax failure. As a non-root user without a writable pid path (CI + most local builds), nginx prints 'syntax is ok' then exits 1 on '[emerg] open(/var/run/nginx.pid) failed (Permission denied)' — a runtime artifact, not a config-syntax error. Gate on the 'syntax is ok' verdict in the output. Regression test with a fake nginx included. Fixes golden-path E2E step 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nself build treated nginx -t exit 1 as a syntax error even when nginx printed 'syntax is ok' — the exit was the pid-file open failing as non-root. Gate on the syntax verdict. Regression test included. Fixes E2E golden path step 4 + real non-root nself build.