Skip to content

Add top-level permissions block to dispatch-review.yaml mirror - #324

Merged
nsheaps merged 2 commits into
mainfrom
fix/dispatch-review-top-level-permissions
Aug 11, 2026
Merged

Add top-level permissions block to dispatch-review.yaml mirror#324
nsheaps merged 2 commits into
mainfrom
fix/dispatch-review-top-level-permissions

Conversation

@nsheaps

@nsheaps nsheaps commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Companion to nsheaps/.github#206. Applies the same top-level permissions: fix (checkov CKV2_GHA_1) to this repo's documentation-only mirror of dispatch-review.yaml.
  • templates/dispatch-review.yaml here isn't wired into nsheaps/.github's sync-files.yml — it's a manually-kept copy per that repo's sync-dispatch-workflows skill instructions ("Also update the convenience mirror... this copy is documentation-only and will silently drift if you forget it").
  • Only the permissions block was added — this copy's gate logic (on.types, the if: condition, unpinned uses: ...@main) has already diverged from the canonical template in nsheaps/.github. That's a separate, pre-existing drift issue and out of scope for this change.

Test plan

  • Diff against nsheaps/.github's canonical template confirms only the permissions block was added, no other changes

Generated by Claude Code

This is a documentation-only mirror of nsheaps/.github's canonical
dispatch-review.yaml template (not wired into sync-files.yml), kept
per that repo's sync-dispatch-workflows skill instructions. Applying
the same top-level permissions fix as the canonical template
(checkov CKV2_GHA_1) without touching this copy's already-diverged
gate logic -- that's a separate, pre-existing drift issue out of
scope here.

nsheaps commented Aug 11, 2026

Copy link
Copy Markdown
Owner Author

test job failure is pre-existing/unrelated to this PR: @nsheaps/agents-plugins:test fails on Error: claude native binary not installed in the validate-plugin task — a CI environment gap, not something this change (a permissions-block-only addition to a template file) could trigger. Same failure pattern already seen on nsheaps/agents#319 earlier in this session. Not fixing here — out of scope.


Generated by Claude Code

@nsheaps
nsheaps marked this pull request as ready for review August 11, 2026 03:18
@nsheaps
nsheaps merged commit 5d07b78 into main Aug 11, 2026
4 of 6 checks passed
@nsheaps
nsheaps deleted the fix/dispatch-review-top-level-permissions branch August 11, 2026 03:18
nsheaps pushed a commit that referenced this pull request Aug 11, 2026
It wasn't covered by nsheaps/.github's sync-files.yml, so it silently
went stale relative to the canonical template multiple times (most
recently #324). Point docs directly at the nsheaps/.github source
instead of maintaining a second copy.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016wPHfMEiz9Bjau7twwZybf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant