Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Semiotic’s streaming chart pipeline to improve canvas hit-testing and to correctly render showPoints for time-series charts (line/area/stacked area), along with corresponding documentation/rules updates for the 3.2.1 release.
Changes:
- Emit point scene nodes for line/area/stacked area when
pointStyleis provided (enablingshowPointson time-series HOCs) and render them viapointCanvasRenderer. - Increase minimum point hit target to 12px (and expand tolerance) across XY/ordinal/network/geo hit testers, updating affected tests.
- Add
showPoints/pointRadiussupport toAreaChartandStackedAreaChart, and update docs + instruction/rules text.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/stream/xySceneBuilders/lineScene.ts | Emits point nodes for line scenes when pointStyle is configured. |
| src/components/stream/xySceneBuilders/areaScene.ts | Emits point nodes for area and stacked area scenes when pointStyle is configured. |
| src/components/stream/StreamXYFrame.tsx | Adds pointCanvasRenderer to line/area/stacked area renderer pipelines. |
| src/components/stream/CanvasHitTester.ts | Updates XY point hit radius calculation to enforce a 12px minimum. |
| src/components/stream/CanvasHitTester.test.ts | Adjusts XY hit testing expectations for the new hit radius. |
| src/components/stream/OrdinalCanvasHitTester.ts | Updates ordinal point hit radius calculation to enforce a 12px minimum. |
| src/components/stream/OrdinalCanvasHitTester.test.ts | Adjusts ordinal hit testing expectations for the new hit radius. |
| src/components/stream/NetworkCanvasHitTester.ts | Updates network circle hit tolerance to enforce a 12px minimum. |
| src/components/stream/GeoCanvasHitTester.ts | Updates geo point hit radius to enforce a 12px minimum. |
| src/components/charts/xy/AreaChart.tsx | Adds showPoints/pointRadius props and passes pointStyle to StreamXYFrame. |
| src/components/charts/xy/StackedAreaChart.tsx | Adds showPoints/pointRadius props and passes pointStyle to StreamXYFrame. |
| docs/src/pages/charts/AreaChartPage.js | Documents new showPoints/pointRadius props. |
| docs/src/pages/charts/StackedAreaChartPage.js | Documents new showPoints/pointRadius props. |
| docs/src/pages/charts/LineChartPage.js | Updates example to include pointRadius and doc overrides. |
| docs/public/llms-full.txt | Updates LLM-facing docs/instructions (e.g., onClick, new charts, tooltip notes). |
| .windsurfrules | Keeps editor rules in sync with updated docs/instructions content. |
| .github/copilot-instructions.md | Keeps Copilot instructions in sync with updated docs/instructions content. |
| .cursorrules | Keeps editor rules in sync with updated docs/instructions content. |
| .clinerules | Keeps editor rules in sync with updated docs/instructions content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve hit-testing. Fix showPoints on time series charts. Docs and package cleanup