Skip to content

3.2.1#807

Merged
emeeks merged 7 commits into
mainfrom
3.2.1
Mar 30, 2026
Merged

3.2.1#807
emeeks merged 7 commits into
mainfrom
3.2.1

Conversation

@emeeks

@emeeks emeeks commented Mar 30, 2026

Copy link
Copy Markdown
Member

Improve hit-testing. Fix showPoints on time series charts. Docs and package cleanup

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Semiotic’s streaming chart pipeline to improve canvas hit-testing and to correctly render showPoints for time-series charts (line/area/stacked area), along with corresponding documentation/rules updates for the 3.2.1 release.

Changes:

  • Emit point scene nodes for line/area/stacked area when pointStyle is provided (enabling showPoints on time-series HOCs) and render them via pointCanvasRenderer.
  • Increase minimum point hit target to 12px (and expand tolerance) across XY/ordinal/network/geo hit testers, updating affected tests.
  • Add showPoints/pointRadius support to AreaChart and StackedAreaChart, and update docs + instruction/rules text.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/components/stream/xySceneBuilders/lineScene.ts Emits point nodes for line scenes when pointStyle is configured.
src/components/stream/xySceneBuilders/areaScene.ts Emits point nodes for area and stacked area scenes when pointStyle is configured.
src/components/stream/StreamXYFrame.tsx Adds pointCanvasRenderer to line/area/stacked area renderer pipelines.
src/components/stream/CanvasHitTester.ts Updates XY point hit radius calculation to enforce a 12px minimum.
src/components/stream/CanvasHitTester.test.ts Adjusts XY hit testing expectations for the new hit radius.
src/components/stream/OrdinalCanvasHitTester.ts Updates ordinal point hit radius calculation to enforce a 12px minimum.
src/components/stream/OrdinalCanvasHitTester.test.ts Adjusts ordinal hit testing expectations for the new hit radius.
src/components/stream/NetworkCanvasHitTester.ts Updates network circle hit tolerance to enforce a 12px minimum.
src/components/stream/GeoCanvasHitTester.ts Updates geo point hit radius to enforce a 12px minimum.
src/components/charts/xy/AreaChart.tsx Adds showPoints/pointRadius props and passes pointStyle to StreamXYFrame.
src/components/charts/xy/StackedAreaChart.tsx Adds showPoints/pointRadius props and passes pointStyle to StreamXYFrame.
docs/src/pages/charts/AreaChartPage.js Documents new showPoints/pointRadius props.
docs/src/pages/charts/StackedAreaChartPage.js Documents new showPoints/pointRadius props.
docs/src/pages/charts/LineChartPage.js Updates example to include pointRadius and doc overrides.
docs/public/llms-full.txt Updates LLM-facing docs/instructions (e.g., onClick, new charts, tooltip notes).
.windsurfrules Keeps editor rules in sync with updated docs/instructions content.
.github/copilot-instructions.md Keeps Copilot instructions in sync with updated docs/instructions content.
.cursorrules Keeps editor rules in sync with updated docs/instructions content.
.clinerules Keeps editor rules in sync with updated docs/instructions content.

Comment thread src/components/stream/StreamXYFrame.tsx
Comment thread src/components/stream/xySceneBuilders/lineScene.ts Outdated
Comment thread src/components/stream/xySceneBuilders/lineScene.ts Outdated
Comment thread src/components/stream/xySceneBuilders/areaScene.ts Outdated
Comment thread src/components/charts/xy/AreaChart.tsx
Comment thread src/components/charts/xy/StackedAreaChart.tsx
Comment thread src/components/stream/xySceneBuilders/areaScene.ts Outdated
Comment thread src/components/stream/xySceneBuilders/areaScene.ts Outdated
Comment thread src/components/stream/xySceneBuilders/lineScene.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated 3 comments.

Comment thread src/components/stream/xySceneBuilders/areaScene.ts Outdated
Comment thread src/components/charts/xy/AreaChart.tsx
Comment thread src/components/charts/xy/StackedAreaChart.tsx

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Comment thread src/components/stream/xySceneBuilders/areaScene.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.

Comment thread src/components/stream/xySceneBuilders/areaScene.ts Outdated
Comment thread src/components/charts/xy/LineChart.tsx

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.

Comment thread src/components/stream/xySceneBuilders/areaScene.ts Outdated
Comment thread src/components/stream/GeoCanvasHitTester.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 32 changed files in this pull request and generated 2 comments.

Comment thread src/components/stream/renderers/pointCanvasRenderer.ts
Comment thread src/components/stream/xySceneBuilders/areaScene.ts Outdated
@emeeks
emeeks merged commit 808590f into main Mar 30, 2026
5 checks passed
@emeeks
emeeks deleted the 3.2.1 branch March 30, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants