chore: test to prod#145
Conversation
# Conflicts: # ebpftracer/ebpf.go
ebpf: improve protocol identification accuracy
instance metadata: add support for Alibaba Cloud
Add version flag and installation of specific version
add support for hybrid cgroup mode with both V1 and V2 enabled
instance metadata: add support for Scaleway
application types: add OpenSearch and VictoriaMetrics
containers: invalidate ignored containers cache
group connections to AWS services by FQDN instead of IPs
application types: add Coroot
enhance accuracy of cgroup2 base path detection
…ation tls: avoid reading the entire `.text` section to reduce memory allocations (#175)
fix detection of actual destination for TCP connections
using FQDNs as destinations when they are resolved into a list of public IPs
…sing improve error handling in ClickHouse protocol parser
chore: rebase upstream
Bumps [github.com/cilium/cilium](https://github.com/cilium/cilium) from 1.17.2 to 1.17.3. - [Release notes](https://github.com/cilium/cilium/releases) - [Changelog](https://github.com/cilium/cilium/blob/1.17.3/CHANGELOG.md) - [Commits](cilium/cilium@1.17.2...1.17.3) --- updated-dependencies: - dependency-name: github.com/cilium/cilium dependency-version: 1.17.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…m/cilium/cilium-1.17.3 build(deps): bump github.com/cilium/cilium from 1.17.2 to 1.17.3
remove usage of Prometheus WAL
add GPU metrics
prometheus: avoid retaining compression buffer between iterations
chore: rebase with upstream
chore: updated log parser
chore: added az/region metric for bytes transferred
chore: fix for high cves
chore: main to test
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mayankpande88, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant enhancements to the node agent, focusing on improving compatibility with diverse container environments (cgroup v1/v2, various runtimes), adding new observability capabilities (GPU metrics, improved JVM profiling), providing more control over monitoring via filtering, and implementing a robust Prometheus remote write mechanism for metrics export. It also includes general updates to dependencies and build processes.
Highlights
- Cgroup Handling Improvements: Refactored cgroup detection and metric collection logic to better support cgroup v1 and v2 environments, including handling different cgroup namespaces and paths like
reserved.slice. - NVIDIA GPU Metrics: Added a new collector to gather NVIDIA GPU usage and memory metrics at both the device and process levels using the NVML library.
- Prometheus Remote Write: Implemented a Prometheus remote write agent to send collected metrics to a configured endpoint, including on-disk spooling for reliability.
- Container and HTTP Filtering: Introduced new flags and logic to allow filtering which containers are monitored based on allow/deny lists (regex) and to exclude HTTP metrics and traces based on request path (glob patterns).
- JVM Profiling Enhancement: Added support for dumping JVM perfmaps using the
jattachmechanism, which can improve profiling symbol resolution for Java applications. - Expanded Cloud Metadata Detection: Added support for detecting and collecting metadata from Alibaba Cloud, Scaleway, and IBM Cloud, and allowed overriding metadata fields via flags.
- Dependency and Build Updates: Updated various Go dependencies, including Cilium eBPF, Docker, Prometheus, and Kubernetes client libraries. Updated Dockerfiles to use newer Go and base images and refined build steps. Updated the install script to support specifying a version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a significant number of features and improvements, including GPU metrics collection, JVM perfmap dumping for profiling, a Prometheus remote write client, container filtering capabilities, and substantial refactoring of cgroup handling for better v2 and unified hierarchy support. Dockerfiles have been updated for newer Go versions and optimized. Application type detection is expanded, and network destination key logic has been refined. Common utility functions and new test fixtures have also been added.
Overall, the changes are extensive and enhance the agent's capabilities significantly. The review focuses on the correctness of new features, robustness of refactored components, and general code quality.
6 participants
No description provided.