Skip to content

fix(tools): set base class for ReSharper dupfinder#1494

Merged
matkoch merged 1 commit intonuke-build:developfrom
Matze693:bugfix/fix-missing-base-class-for-dupfinder
Jan 15, 2025
Merged

fix(tools): set base class for ReSharper dupfinder#1494
matkoch merged 1 commit intonuke-build:developfrom
Matze693:bugfix/fix-missing-base-class-for-dupfinder

Conversation

@Matze693
Copy link
Contributor

Fixed missing base class for ReSharper dupfinder to solve crash when using ReSharperDupFinder:

System.InvalidCastException: Unable to cast object of type 'Nuke.Common.Tools.ReSharper.ReSharperDupFinderSettings' to type 'Nuke.Common.Tools.ReSharper.ReSharperSettingsBase'.
   at Nuke.Common.Tools.ReSharper.ReSharperTasks.PreProcess(ToolOptions options) in /_/source/Nuke.Common/Tools/ReSharper/ReSharperTasks.cs:line 22
   at Nuke.Common.Tooling.ToolTasks.Run[T](ToolOptions options) in /_/source/Nuke.Tooling/ToolTasks.Run.cs:line 23
   at Nuke.Common.Tools.ReSharper.ReSharperTasks.ReSharperDupFinder(Configure`1 configurator) in /_/source/Nuke.Common/Tools/ReSharper/ReSharper.Generated.cs:line 49

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@matkoch
Copy link
Member

matkoch commented Dec 16, 2024

FYI, DupFinder has been sunsetted for a long time already.

@Matze693
Copy link
Contributor Author

FYI, DupFinder has been sunsetted for a long time already.

I know, but I thought that as long as it is a part of Nuke, it should be able to execute. Alternatively, it can also be removed completely.

@matkoch matkoch merged commit 08cce01 into nuke-build:develop Jan 15, 2025
@matkoch matkoch added this to the v9.0.4 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants