Add commands for create/delete service keys#53
Merged
patrickcrocker merged 9 commits intonulldriver:masterfrom Mar 20, 2019
Identifix:master
Merged
Add commands for create/delete service keys#53patrickcrocker merged 9 commits intonulldriver:masterfrom Identifix:master
patrickcrocker merged 9 commits intonulldriver:masterfrom
Identifix:master
Conversation
added 9 commits
January 31, 2019 21:39
latest from base
Add ability to create and delete service keys.
Fix service_key extraction from options due to copy paste error.
Fix service_key extraction from options due to copy paste error.
Update README to add info on service key commands.
Member
|
Thank s for the PR! I've put in a couple of review items I'd like you to take a look at. I've also added issue #56 to explore modifying the integration tests to use an existing org and/or space for tests. |
Author
|
I'm not seeing the review items. This is my first OSS pull request, so I may just be missing something when merging back from a fork. |
Member
|
Hmm... not sure why you aren't seeing it. I just released v2.11.0 so I'll take a look at merging your pull request sometime this week and implementing the |
patrickcrocker
previously requested changes
Feb 27, 2019
Member
|
@brentdemark ok, I figured out what I did wrong with the review... you should now have the requested changes as part of the review! |
patrickcrocker
dismissed
their stale review
Dismissing review, will make changes myself :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the commands to create and delete service keys and tested them out. However, I haven't been able to run the actual tests as I don't have the permissions within our environment to create orgs. Is there I a way I can verify that the tests work without this?