fix(supervisor): close adapter subscription and log-filter gaps - #99
Merged
Conversation
…d name fallbacks AI Assistance: Claude Fable 5 used for implementation and tests
AI Assistance: Claude Fable 5 used for implementation and tests
AI Assistance: Claude Fable 5 used for implementation and tests
…-log filters AI Assistance: Claude Fable 5 used for implementation and tests
…e table AI Assistance: Claude Opus 5 used for review and the fix
…e refusal point AI Assistance: Claude Opus 5 used for review and the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends the chain-log fail-closed gate from #65 to the two remaining escape paths: adapter
[[subscriptions]]entries and chain-log filter values.load_providernow reads the adapter manifest's subscriptions and refuses boot on a chain not present inengine_cfg.chains, matching the module-side check.Chain-log filter
addressandevent_signaturevalues are validated at load time and refuse boot on a parse failure, instead of being warn-skipped when the collection-time subscription list is rebuilt.The
boot_singlemanifest role now comes from theRoletable (promoted to its ownsupervisor::rolemodule) instead of a name-based fallback, and the provider/module load loops and telemetry helpers are folded to share that role-keyed path.Why
Closes #80
The red-team on #65 found both gaps out of that PR's scope by design: adapter subscriptions never went through
load_provider's chain check, and invalid filter values only warned at collection time rather than failing the boot that declared them. Both are the same fail-open family as #65 and belong on the same pre-compile, config-keyed gate.Testing
cargo nextest run -p nexum-runtime supervisor::tests::chain_gate covering:
boot_refuses_an_adapter_subscription_on_an_unconfigured_chain(adapter subscription past[chains]refuses beforeread component/compile),boot_refuses_an_invalid_chain_log_filter(bad address and bad topic each refuse boot with the offending detail in the message), anda_validated_chain_log_filter_survives_to_the_collected_subscription(a valid filter boots alive and the collected subscription's serialised filter carries the same address and topic).unconfigured_chain_message_says_none_when_engine_toml_declares_no_chainsupdated for the newRoleparameter on the shared refusal-message builder.AI Assistance
Implementation by Claude Fable 5, red-team review by Claude Opus 5, PR by Claude Sonnet 5.