twap-monitor: rename strategy module to keeper - #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename twap-monitor's
strategymodule tokeeperand adopt keeper vernacular in its module docs andmodule.toml, so the module reads as the keeper it is rather than "strategy logic". Scoped tomodules/twap-monitoronly.Why
ethflow-watcher is observe-only and stop-loss was deleted, so twap-monitor is the sole remaining submitter keeper. Its docs described it as strategy logic, out of step with the keeper vocabulary the SDK now uses (
composable_cow::run,Keeper::run).Testing
cargo fmt --all -- --check,cargo clippy --workspace --all-targets --all-features --locked -D warnings, all 17 guest wasms,cargo nextest run --workspace --all-features --locked,cargo test --doc,RUSTDOCFLAGS=-D warnings cargo doc --workspace --no-deps --locked,scripts/check-venue-agnostic.sh,scripts/check-cow-orderbook-only.sh.AI Assistance
Implemented with Claude Code.
Closes #522