Skip to content

Adapt mock to current version of the mocked library.#6

Merged
nullivex merged 1 commit intonullivex:masterfrom
carlosbaraza:master
May 20, 2015
Merged

Adapt mock to current version of the mocked library.#6
nullivex merged 1 commit intonullivex:masterfrom
carlosbaraza:master

Conversation

@carlosbaraza
Copy link
Copy Markdown
Contributor

Modification: Return a constructor when calling the Provider, like the current version of the original library that is being mocked.

I did this modification to make it work with the lates version I am using of all the libraries.

Let me know if you would like to handle this in a different way or you would like me to do any modification.

Great and useful mock!
Carlos.

…ion of the original library that is being mocked.
@nullivex
Copy link
Copy Markdown
Owner

nullivex commented Mar 2, 2015

So this change is going to break this module against older versions right?

Thus we need to make two branches I think. One for the older style that is on there now and one for the newer style?

Or should we leave it mainline and just document the version that it changed. Older libraries install the older version. That sounds cleanest to me.

@marklawlor
Copy link
Copy Markdown
Contributor

I'd like to see this pull request merged, as this library no longer works with angular-mock-io.

If your concerned about breaking older versions, I'd recommend increasing the semver to 1.0.0 as this will be major breaking change.

@nullivex
Copy link
Copy Markdown
Owner

Okay,

Ya I will merge this into a new major version and update the docs. Sorry I must have missed this in my email.

nullivex added a commit that referenced this pull request May 20, 2015
Adapt mock to current version of the mocked library.
@nullivex nullivex merged commit 977c46e into nullivex:master May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants