Adapt mock to current version of the mocked library.#6
Merged
nullivex merged 1 commit intonullivex:masterfrom May 20, 2015
Merged
Adapt mock to current version of the mocked library.#6nullivex merged 1 commit intonullivex:masterfrom
nullivex merged 1 commit intonullivex:masterfrom
Conversation
…ion of the original library that is being mocked.
Owner
|
So this change is going to break this module against older versions right? Thus we need to make two branches I think. One for the older style that is on there now and one for the newer style? Or should we leave it mainline and just document the version that it changed. Older libraries install the older version. That sounds cleanest to me. |
Contributor
|
I'd like to see this pull request merged, as this library no longer works with angular-mock-io. If your concerned about breaking older versions, I'd recommend increasing the semver to 1.0.0 as this will be major breaking change. |
Owner
|
Okay, Ya I will merge this into a new major version and update the docs. Sorry I must have missed this in my email. |
nullivex
added a commit
that referenced
this pull request
May 20, 2015
Adapt mock to current version of the mocked library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modification: Return a constructor when calling the Provider, like the current version of the original library that is being mocked.
I did this modification to make it work with the lates version I am using of all the libraries.
Let me know if you would like to handle this in a different way or you would like me to do any modification.
Great and useful mock!
Carlos.