fix(docker-build-push-ecr): build backfills from the tag, not the dispatch branch - #100
Open
sebasnallar wants to merge 1 commit into
Open
fix(docker-build-push-ecr): build backfills from the tag, not the dispatch branch#100sebasnallar wants to merge 1 commit into
sebasnallar wants to merge 1 commit into
Conversation
…patch branch The checkout was bare, so an existing_tag recovery dispatch built the image from the branch that dispatched it instead of the tagged commit — correct only when they coincide. Adds an optional ref input (empty = triggering ref, preserving normal behavior) and passes existing_tag through from release-publish-oci's publish call. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latent correctness bug in every
existing_tagrecovery path:docker-build-push-ecr.ymldid a bare checkout, so a backfill dispatched from a branch built the image from that branch's head, not from the tagged commit. It has only worked so far because the dispatches happened while the branch head and the tag coincided.Changes
docker-build-push-ecr.yml: optionalrefinput (default''= the triggering ref — normal tag-push behavior unchanged), wired into the checkout.release-publish-oci.yml: the publish call passesref: ${{ inputs.existing_tag || '' }}, so every caller's backfill now builds the tag's actual content.Needed for the scopes v1.16.1 recovery (nullplatform/scopes#240 passes the same
reffrom its dispatch) — that plan deliberately never touches the existing tag.🤖 Generated with Claude Code