Skip to content

fix(k8s): stop hardcoding the CloudWatch logging annotations - Beta #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andres-nullplatform merged 4 commits into from
Aug 13, 2026
Merged

fix(k8s): stop hardcoding the CloudWatch logging annotations - Beta #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e59b94
chore: merge beta into main for 1.14.0 release
fedemaleh Aug 3, 2026
8812bbc
Merge pull request #211 from nullplatform/chore/merge-beta-into-main
fedemaleh Aug 3, 2026
ab25bb7
Merge pull request #217 from nullplatform/beta
fedemaleh Aug 10, 2026
07dee78
fix(k8s): stop hardcoding the CloudWatch logging annotations
andres-nullplatform Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
- Remove unused cloudwatch annotations from deployment objects

## [1.15.0] - 2026-08-10
- Fix: **finalize** and **rollback** on blue/green k8s scopes now wait until the load balancer sends all traffic to the surviving deployment before deleting the other one, preventing the 5xx window that happened when it was deleted mid-switch (these actions may take slightly longer as a result)
Expand Down
6 changes: 0 additions & 6 deletions k8s/deployment/templates/deployment.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,6 @@ spec:
{{- end }}
{{- end }}
annotations:
nullplatform.logs.cloudwatch: 'true'
nullplatform.logs.cloudwatch.log_group_name: {{ .namespace.slug }}.{{ .application.slug }}
nullplatform.logs.cloudwatch.log_stream_log_retention_days: '7'
nullplatform.logs.cloudwatch.log_stream_name_pattern: >-
type=${type};application={{ .application.id }};scope={{ .scope.id }};deploy={{ .deployment.id }};instance=${instance};container=${container}
nullplatform.logs.cloudwatch.region: {{ .region }}
{{- $global := index .k8s_modifiers "global" }}
{{- if $global }}
{{- $annotations := index $global "annotations" }}
Expand Down
6 changes: 0 additions & 6 deletions scheduled_task/deployment/templates/deployment.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,6 @@ spec:
{{- end }}
{{- end }}
annotations:
nullplatform.logs.cloudwatch: 'true'
nullplatform.logs.cloudwatch.log_group_name: {{ .namespace.slug }}.{{ .application.slug }}
nullplatform.logs.cloudwatch.log_stream_log_retention_days: '7'
nullplatform.logs.cloudwatch.log_stream_name_pattern: >-
type=${type};application={{ .application.id }};scope={{ .scope.id }};deploy={{ .deployment.id }};instance=${instance};container=${container}
nullplatform.logs.cloudwatch.region: us-east-1
{{- $global := index .k8s_modifiers "global" }}
{{- if $global }}
{{- $annotations := index $global "annotations" }}
Expand Down
Loading