feat(k8s): allow cluster-wide traffic-manager version override via container-orchestration provider - #231
Merged
Conversation
…ntainer-orchestration provider Adds a provider-based layer for the traffic-manager sidecar version, mirroring the pattern already used by main_traffic_manager_port. The container-orchestration provider's traffic_manager.version now sets the default image tag for non-websocket scopes, while web_sockets scopes keep forcing websocket2 regardless of the provider. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fedemaleh
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main_traffic_manager_portpattern:container-orchestration.traffic_manager.versionnow sets the default image tag for non-websocket k8s scopes.web_socketsscopes keep forcing thewebsocket2tag regardless of the provider (protocol-specific default still wins).TRAFFIC_CONTAINER_IMAGE(env var /scope-configurations.deployment.traffic_container_imageprovider) is unchanged and still takes priority when set, since it overrides the full image reference rather than just the tag.Test plan
bats k8s/deployment/tests/build_context.bats— all traffic-container tests pass (4 new cases: websocket vs http, provider version set, websocket ignores provider, end-to-end default image resolution). Two pre-existing replica-calculation failures are unrelated to this change (reproduced onbetatoo).module.container_orchestration(nullplatform/container_orchestration/eks) publishing the provider, pointed the live agent at this branch, and confirmed the deployedcontainer-orchestrationprovider config resolvestraffic_manager.version.🤖 Generated with Claude Code