Skip to content

docs: don't duplicate the scope's notification channel for the container-scope-override - #3

Merged
sebastiancorrea81 merged 1 commit into
mainfrom
fix/scope-channel-association-duplicate-notification-channel
Jul 21, 2026
Merged

docs: don't duplicate the scope's notification channel for the container-scope-override#3
sebastiancorrea81 merged 1 commit into
mainfrom
fix/scope-channel-association-duplicate-notification-channel

Conversation

@sebastiancorrea81

Copy link
Copy Markdown
Contributor

Summary

  • The README's step 3 example (scope_channel_association) registers a second scope_definition_agent_association-based module call pointed at the same scope_specification_id/scope_specification_slug as the scope's existing agent-association channel.
  • The channel's filters are built solely from scope_specification_slug/scope_specification_id (see nullplatform/scopes's k8s/specs/notification-channel.json.tpl). enabled_override only appends --overrides-path=... to the cmdline — it doesn't change the filter.
  • So two module calls for the same scope create two nullplatform_notification_channel resources with identical filters: every action notification fires both, duplicating the base entrypoint execution (one of the two additionally runs the override sync).

Change

  • Documents adding enabled_override / override_repo_path / overrides_service_path directly to the scope's existing scope_definition_agent_association module call, when one already exists in the project.
  • Keeps the original scope_channel_association (for_each) example for the case where the target scope has no existing agent association yet.

Docs-only change, found while wiring path-router into a scope that already had its own agent association.

Test plan

  • Reviewed rendered README locally for formatting/link correctness.
  • N/A — no code change.

…ing agent association

The scope_channel_association example created a second
scope_definition_agent_association-based module call pointed at the same
scope_specification_id/slug as the scope's existing channel. Both resources
end up with identical filters (built only from slug/id), so every action
notification for that scope fires both channels, duplicating the base
entrypoint execution. Documents adding enabled_override/override_repo_path/
overrides_service_path to the existing module call instead, when one exists.
@sebastiancorrea81
sebastiancorrea81 merged commit 6b03e6c into main Jul 21, 2026
5 checks passed
@sebastiancorrea81
sebastiancorrea81 deleted the fix/scope-channel-association-duplicate-notification-channel branch July 21, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant