fix(ci): compare release PR author against REST-style bot login - #481
Merged
Conversation
The find-pr job introduced in #479 used `gh pr list --json author`, whose --json output is GraphQL-backed and represents github-actions[bot] as "app/github-actions" — not "github-actions[bot]" like the REST API's user.login (what the old pull_request-triggered version, and the reusable workflow's release_pr_author default, compare against). Confirmed live: the first real workflow_run after #479 merged found PR #476 but skipped it with "Open PR doesn't match expected author/label", leaving it unmerged. Switch the lookup to `gh api .../pulls` (REST) so user.login matches github-actions[bot] as expected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sebastiancorrea81
added a commit
that referenced
this pull request
Aug 7, 2026
🤖 I have created a release *beep* *boop* --- ## [6.10.0](v6.9.0...v6.10.0) (2026-08-07) ### Features * **service_definition:** forward link spec fields from the template ([#477](#477)) ([2994e6b](2994e6b)) ### Bug Fixes * **ci:** compare release PR author against REST-style bot login ([4e00860](4e00860)) * **ci:** compare release PR author against REST-style bot login ([#481](#481)) ([75a16ea](75a16ea)) * **ci:** trigger release PR auto-merge via workflow_run instead of pull_request ([e7eff48](e7eff48)) * **ci:** trigger release PR auto-merge via workflow_run instead of pull_request ([#479](#479)) ([80738de](80738de)) * **eks:** support an optional aws_profile for the kubernetes provider exec plugin ([#471](#471)) ([ccb2f5f](ccb2f5f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sebastiancorrea81
added a commit
that referenced
this pull request
Aug 7, 2026
Small, low-risk change used as a real trigger to test the full post-merge automation chain (#479, #481, nullplatform/actions-nullplatform#89) end-to-end on a clean cycle: this PR's merge → release-please PR → auto-merge (workflow_run + REST author check + --admin) → tag/release, with no manual step in between. Root README's usage example pinned `infrastructure/aws/vpc` to `v1.56.1`, several major versions behind the current `v6.10.0` — updated so copy-pasting the example doesn't point at a stale tag. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #479. Confirmed live right after #479 merged: the new
find-prjob ran and correctly located PR #476, but skipped it with "Open PR doesn't match expected author/label", leaving the release PR un-merged.Root cause:
gh pr list --json authoris GraphQL-backed and representsgithub-actions[bot]as"app/github-actions", not"github-actions[bot]". The comparison infind-pr(and the reusable workflow'srelease_pr_authordefault, and the oldpull_request-triggered version'sgithub.event.pull_request.user.login) all expect the REST-style"github-actions[bot]".Fix
Switch the PR lookup from
gh pr list --json authortogh api repos/{repo}/pulls?state=open&head={owner}:release-please--branches--main(REST), whoseuser.loginis"github-actions[bot]"as expected. Verified locally against the real PR #476 before pushing.Test plan
auto-merge-release-pr(workflow_run) run resolvespr_numberfor PR chore(main): release 6.10.0 #476 and actually merges it this time.🤖 Generated with Claude Code