Spawn GRANDPA observer task for non-validator nodes - #73
Merged
Conversation
The non-authority branch of new_full() was dropping the grandpa notification stream returned from the grandpa block import setup. That immediately closed the corresponding essential task and any follow-up grandpa peer dialing failed, leaving full nodes stuck at 0 peers and unable to follow finality. Mirror the authority branch but pass keystore=None so non-authority nodes participate as observers only (no voting, no equivocation reporting).
motoZ-crypto
added
T-bug
motoZ-crypto
marked this pull request as ready for review
May 1, 2026 08:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-authority branch of new_full() was dropping the grandpa notification stream returned from the grandpa block import setup. That immediately closed the corresponding essential task and any follow-up grandpa peer dialing failed, leaving full nodes stuck at 0 peers and unable to follow finality.
Mirror the authority branch but pass keystore=None so non-authority nodes participate as observers only (no voting, no equivocation reporting).