Override new_session_genesis to fix initial set - #74
Merged
Conversation
Without an explicit override, `pallet-session` would call our `new_session(0)` which compares the freshly built `ActiveValidators` against the same value and returns `None`, making session pallet fall back to the union of all `session.keys` accounts as the genesis authority set. That includes accounts only registered for future runtime promotion (Dave/Eve in the integration preset), which is incorrect: only `initial_validators` should be active at block 0.
motoZ-crypto
added
T-bug
motoZ-crypto
marked this pull request as ready for review
May 1, 2026 09:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without an explicit override,
pallet-sessionwould call ournew_session(0)which compares the freshly builtActiveValidatorsagainst the same value and returnsNone, making session pallet fall back to the union of allsession.keysaccounts as the genesis authority set. That includes accounts only registered for future runtime promotion (Dave/Eve in the integration preset), which is incorrect: onlyinitial_validatorsshould be active at block 0.