Conversation
|
Expanding on my comment on the mailing list that @shoyer agreed with, how about adding something like: Code that uses |
|
@rgommers thanks for taking the time to write down your suggestion, I agree with it and my apologies, it looks like I misunderstood your argument at the mailing list. The new commit adds that, let me know what you think. |
|
Thanks @shoyer for the great review, trying to simplify the example I ended up simplifying it so much that it was just concatenating. All should be fixed now in the latest commit. :) |
|
This all LGTM, should have been merged a while ago. Thanks @pentschev and @shoyer |
|
Thanks @rgommers for merging, I didn't follow-up on this before because we still had the naming discussion open, but this can always be addressed on a new PR. |
|
Indeed. This is still a significant improvement as is and status is still Draft, so good to have the rendered version in the docs up-to-date |
Update NEP-30, as per discussion in mailing list.