Skip to content

Conversation

@seberg
Copy link
Member

@seberg seberg commented Nov 6, 2020

No description provided.

@eric-wieser
Copy link
Member

We should maybe have a test for this type of thing somewhere - verifying that only objects actually in the np. namespace have __module__ set this way.

@seberg
Copy link
Member Author

seberg commented Nov 6, 2020

Probably, the sanity checks in the __array_function__ wrapper should likely also be moved into test rather than import time. Right now I don't think we have tests for all of these symbols I hopened an issue with the comment, tests are fine, i will just merge it and hope I didn't miss another place.

@seberg seberg merged commit 5f071c6 into numpy:master Nov 6, 2020
@seberg seberg deleted the sliding-view-not-main branch November 6, 2020 16:01
@deepthisreekvs
Copy link

This issue is resolved and it is in private function ._stride_tricks_impl
image

@seberg
Copy link
Member Author

seberg commented Sep 24, 2024

Ah, I didn't realize this there. The issue gh-17724 is about adding tests for this (ideally for all functions), so that such errors don't happen in the future.

@charris charris changed the title MAINT: Do not override sliding_window_view module to numpy MAINT: Do not override sliding_window_view module to numpy Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants