TST: Make this sysconfig handling a bit more portable #19884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
reviewed
Sep 16, 2021
In particular this supports Pyston, which has an additional format field in these path schemes. Instead of manually specifying which fields we think exist, do what I assume is the intention of using the default field values for everything except for the few that we want to override.
kmod
force-pushed
the
support_pyston
branch
from
02a3b48 to
0daa86b
Compare
|
I was worried about there being a semantic difference between |
|
Thanks! Looks right to me. And since this only affects developers anyway, lets put it in. |
kmod
added a commit
to kmod/pyston
that referenced
this pull request
Sep 17, 2021
When I first tried this we had an issue with their test runner, but I fixed it here: numpy/numpy#19884
kmod
added a commit
to kmod/pyston
that referenced
this pull request
Sep 18, 2021
When I first tried this we had an issue with their test runner, but I fixed it here: numpy/numpy#19884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this supports Pyston, which has an additional
format field in these path schemes. Instead of manually
specifying which fields we think exist, do what I assume is the
intention of using the default field values for everything
except for the few that we want to override.
I believe @mattip wrote this code originally