DOC: random: Fix a mistake in the zipf example. #20350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake in the code that generated the plot in the zipf docstring. The Riemann zeta function is `scipy.special.zeta`, not `scipy.special.zetac`. I also tweaked the sample parameters and the plot code so the plot is a bit more informative.
|
The updated docstring with the new plot is at The TravisCI failures are stalled builds or git issues not related to this PR, and it looks like the other failures are also unrelated and will be fixed by #20347. |
|
Definite improvement. |
|
Should this also be fixed in the numpy.random.zipf docstring? Looks like it was just copied over |
|
@melissawm, I pushed a change that updates I also fixed the docs where they said |
|
I only pushed a tiny formatting nit - thanks @WarrenWeckesser ! |
|
Thanks @melissawm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake in the code that generated
the plot in the zipf docstring. The Riemann
zeta function is
scipy.special.zeta, notscipy.special.zetac.I also tweaked the sample parameters and the plot
code so the plot is a bit more informative.