-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
BUG, DIST: Print os error message when the executable not exist #20353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae6a660 to
25aa25c
Compare
|
Doing some testing: gives: So it changes exit status from Maybe That message is just hard to miss in the output, because you have to scroll up quite a bit and then there are no blank lines around the output. How about we add a few blank lines above and below |
shell environment returns So I thought it would be better to not follow this way in case of the build log is redirected to file instead of stdout to make it easier to trace but after reconsidering I think it's a bad idea since it may make the user mixup between parent and subprocess error numbers.
yes, it would be nice |
this patch is really important since most of the users aren't able to determine the build error when the toolchain or the built environment missing executable files of compiler, linker, assembler, etc.
25aa25c to
6d69886
Compare
|
errno reverted to 127 and blank lines added above and after the OS error. export CC=NO_SI_SI
python setup.py build
....
build_src
building py_modules sources
building library "npymath" sources
[Errno 2] No such file or directory: 'NO_SI_SI'
Traceback (most recent call last):
File "/home/seiko/work/repos/numpy/setup.py", line 450, in <module>
setup_package()
File "/home/seiko/work/repos/numpy/setup.py", line 442, in setup_package
setup(**metadata)
File "/home/seiko/work/repos/numpy/numpy/distutils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @seiko2plus!
this patch is really important since most of the users aren't able to determine
the build error when the toolchain or the built environment missing
executable files of compiler, linker, assembler, etc.
related to #20335