TST: remove usage of ProcessPoolExecutor in stringdtype tests #26006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #25875.
The tests are hanging, not crashing, so the behavior looks like a deadlock. This is the only use of
ProcessPoolExecutorin the numpy tests and the tests seem to hang on this test.That said, I'm not sure why the deadlock would only happen in a build of python running under address sanitizer.
Looking at the test again, I don't think this is actually a useful thing to test, since it shouldn't matter if the pickle file is loaded in the process that saved it or not.
So since I suspect this will fix the test hangs, I think this is worth pulling in.