BUG: fix setxor1d when input arrays aren't 1D #26559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See numpy#14670. Previously, when `assume_unique=True`, `setxor1d` attemptes to concatenate arrays with potentially incompatible dimensions. The choice to call `np.ravel` instead of enforcing that the input arrays are 1D stems from the consensus in the linked issue to avoid breaking existing code.
JuliaPoo
force-pushed
the
issue-14670-setxor1d-docs
branch
from
f339e74 to
6ca3e7d
Compare
seberg
reviewed
May 28, 2024
Member
seberg
left a comment
seberg
left a comment
There was a problem hiding this comment.
Thanks, LGTM, although I don't think there is need for a doc change and we can possibly simplify it even more.
To some degree the new tests are the important thing :). I wouldn't mind creating a new function for them (it is often nice to have smaller chunks if a test fails).
Contributor
Author
|
Okie, I've modified the PR to your comments. |
Member
|
Thanks @JuliaPoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14670.
When
assume_unique=True,setxor1dattemptes to concatenate arrays with potentially incompatible dimensions. The fix implemented here callsnp.ravelon the input arrays. The choice to callnp.ravelinstead of enforcing that the input arrays are 1D comes from the consensus in the linked issue to avoid breaking existing code.