-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
DOC: update ufunc tutorials to use setuptools #26566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update ufunc tutorials to use setuptools #26566
Conversation
See numpy#22027. Currently ufunc tutorials use depreciated distutils which is removed in Python 3.12. In addition, I've updated the sample output and fixed a mistake in the last example.
|
I wonder if we could convert this tutorial (and the others like the cython one to use meson. The extending random examples have a meson.build file, but the documentation is a little sparse. The f2py migration guide is a little better, but could also use some fleshing out. |
|
Thanks @JuliaPoo!
I think that is a much larger exercise, and best done separately if someone has energy for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great to have documentation that actually works! And thanks for going through it carefully and ensuring the outputs are actually correct, etc.
Also indeed fine to just use setuptools for these examples - others can be added later if need be.
All my comments are nitpicks, of the "please align" and "please combine lines" type.
|
Okie I've modified the PR to these comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Looks all OK now, so let's get this in.
Backports of numpy#26504, numpy#26517, and numpy#26566. [skip azp] [skip azure] [skip cirrus] commit e9fca3ee60006969d0e2c18b9e04f6a0fe6f6bc8 Author: Jules <57632293+JuliaPoo@users.noreply.github.com> Date: Thu May 30 20:27:28 2024 +0800 DOC: update ufunc tutorials to use setuptools (numpy#26566) * DOC: update ufunc tutorials to use setuptools See numpy#22027. Currently ufunc tutorials use depreciated distutils which is removed in Python 3.12. In addition, I've updated the sample output and fixed a mistake in the last example. commit 04cb2596fbce4a12dc88c3200b8940764c1d1711 Author: Mateusz Sokół <mat646@gmail.com> Date: Fri May 24 11:12:38 2024 +0200 Add np.alltrue to migration guide [skip actions] [skip azp] [skip cirrus] commit d05bce7388b96aaf8a3ac557228ea8cfb13daffe Author: warren <warren.weckesser@gmail.com> Date: Wed May 22 14:31:45 2024 -0400 DOC: Copy-edit numpy 2.0 migration guide. Fix a few typos and do a touch of copy-editing. [skip actions] [skip azp] [skip cirrus]
|
@rgommers already backported. |
|
oops sorry, I missed that. thanks! |
See #22027. Currently ufunc tutorials use depreciated distutils which is removed in Python 3.12. In addition, I've updated the sample output and fixed a mistake in the last example.