Skip to content

Conversation

@JuliaPoo
Copy link
Contributor

@JuliaPoo JuliaPoo commented Jun 5, 2024

This is a follow up of #26602 and #24162 where previously the test fails on clang-cl. I've tried a few CI runs on my fork and it seems the test passes now.

This is a follow up of numpy#26602 and numpy#24162 where previously
the test fails on Clang-cl. I've tried a few CI runs on my
fork and it seems the test passes now.
Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI checks.

@mattip mattip merged commit c41621b into numpy:main Jun 5, 2024
@mattip
Copy link
Member

mattip commented Jun 5, 2024

Thanks @JuliaPoo for following up.

@rgommers rgommers added this to the 2.1.0 release milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants