BUG: fancy indexing copy#26868
Merged
Merged
Conversation
* BUG: fancy indexing copy * Fixes numpygh-26542 * For these very simple advanced indexing cases, if the `result` and `self` arrays share the same data pointers, use a copy of `result` to assign values to `self`, otherwise the outcome of the fancy indexing suffers from mutation of `result` before the assignments are complete. * MAINT, BUG: PR 26558 revisions * Avoid leaking the old `tmp_arr`, based on reviewer feedback. * Add a test for a similar 2D case that fails, then hoist `solve_may_share_memory()` check farther up in the control flow such that the test passes. * Add a reviewer-requested test for index overlap. * BUG: PR 26558 revisions * The usage of `solve_may_share_memory` in the above PR wasn't quite right since it ignored the case of failing to solve the overlap problem. This has been revised according to reviewer feedback. Co-authored-by: Sebastian Berg <sebastianb@nvidia.com> --------- Co-authored-by: Sebastian Berg <sebastianb@nvidia.com>
charris
added
00 - Bug
component: numpy._core
08 - Backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26558.
BUG: fancy indexing copy
Fixes Fancy indexing fails on a[idx] = a #26542
For these very simple advanced indexing cases, if the
resultandselfarrays share the samedata pointers, use a copy of
resultto assignvalues to
self, otherwise the outcome of the fancy indexing suffers from mutation ofresultbeforethe assignments are complete.
MAINT, BUG: PR 26558 revisions
Avoid leaking the old
tmp_arr, based on reviewer feedback.Add a test for a similar 2D case that fails, then hoist
solve_may_share_memory()check farther up in the control flow such that the test passes.Add a reviewer-requested test for index overlap.
BUG: PR 26558 revisions
The usage of
solve_may_share_memoryin the above PR wasn't quite right since it ignored the case of failing to solve the overlap problem. This has been revised according to reviewer feedback.