TYP: Improved numpy.generic rich comparison operator type annotations.
#26942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
changed the title
numpy.generic rich comparison operator type annotations.numpy.generic rich comparison operator type annotations.
jorenham
force-pushed
the
improved-comparison-op-typing
branch
from
616fc58 to
d58b26c
Compare
|
It looks like there are some flaky tests? |
jorenham
force-pushed
the
improved-comparison-op-typing
branch
from
d58b26c to
70a7a41
Compare
Not uncommon - you can simply ignore them if they're clearly unrelated. A red CI isn't blocking for merge. |
rgommers
approved these changes
Jul 23, 2024
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects
numpy.genericsubtypes that implement__lt__,__le__,__gt__, or (but usually "and")__ge__.Note that there are no commutativity issues here, because the numpy implementations of these comparison ops always return a
np.boolscalar or array, regardless of the return type of the respective reflected comparison op of the "other" operand.And in the case that the
genericsubtype is on the right-hand side, type checkers will first consider the respective dunder method of the left-hand side.