TYP: Replace typing.Optional[T] with T | None in the numpy.typing tests
#26954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
reviewed
Jul 17, 2024
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
|
That PR is a bit old, but I should resurrect it, and I think there was "sufficient" consensus on it: gh-23119. |
ArvidJB
pushed a commit
to ArvidJB/numpy
that referenced
this pull request
Nov 1, 2024
…typing`` tests (numpy#26954) Since Python 3.10 typing.Optional[T] has been deprecated in favour of the T | None syntax. See https://typing.readthedocs.io/en/latest/spec/historical.html#union-and-optional .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.10
typing.Optional[T]has been deprecated in favour of theT | Nonesyntax.See https://typing.readthedocs.io/en/latest/spec/historical.html#union-and-optional .
Note that the remaining
typing.Optionaluses innumpy._array_api_infoare already dealt with in #26873.