ENH: Add __slots__ to private (sub-)classes in numpy.lib._index_tricks_impl
#26996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
__slots__to the (private) classes innumpy.lib._index_tricks_impland their subclasses, improving the performance of:numpy.mgridnumpy.ogridnumpy.r_numpy.c_numpy.index_expnumpy.s_numpy.ma.mr_Note
I initially wanted to add
__slots__tondenumerateandndindexas well, but decided not to, as there's a (small) chance that it will be backwards compatible.:Because they are part of the public API, and not marked as
@final, it's possible that > they're used as base-class for user-defined types. And while that, on its own, is not a problem here, it could become one if such a user-defined type has more than one base class.But if this isn't a problem, I'd be happy to add
__slots__to these classes, too :)