-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
TST: Refactor to consistently use CompilerChecker #27051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The remaining test failures on Windows are real errors, not related to the compiler presence, which were previously being suppressed. 2024-07-26T14:35:17.6418897Z FAILED: test_array_from_pyobj_ext.cp310-win32.pyd
2024-07-26T14:35:17.6419172Z
2024-07-26T14:35:17.6423831Z "link" /MACHINE:x86 /OUT:test_array_from_pyobj_ext.cp310-win32.pyd test_array_from_pyobj_ext.cp310-win32.pyd.p/112443d308cc40139cb5e53d97c4d31678bcb07b_f2py_tests_src_array_from_pyobj_wrapmodule.c.obj test_array_from_pyobj_ext.cp310-win32.pyd.p/26ebc5753ea73c490d2b7fd0b1c7c485b8e26306_.._.._f2py_src_fortranobject.c.obj "/LIBPATH:C:/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0" "/LIBPATH:C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.1.0" "/LIBPATH:C:/mingw64/lib/gcc" "/LIBPATH:C:/mingw64/bin/../lib/gcc" "/LIBPATH:C:/mingw64/x86_64-w64-mingw32/lib" "/LIBPATH:C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.1.0/../../../../x86_64-w64-mingw32/lib/../lib" "/LIBPATH:C:/mingw64/lib" "/LIBPATH:C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.1.0/../../../../lib" "/LIBPATH:C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.1.0/../../../../x86_64-w64-mingw32/lib" "/LIBPATH:C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.1.0/../../.." "/release" "/nologo" "/OPT:REF" "/DLL" "/IMPLIB:test_array_from_pyobj_ext.cp310-win32.lib" "C:\hostedtoolcache\windows\Python\3.10.11\x86\libs\python310.lib" "quadmath.lib" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib" "gfortran.lib"
2024-07-26T14:35:17.6428982Z
2024-07-26T14:35:17.6429200Z LINK : fatal error LNK1181: cannot open input file 'quadmath.lib' |
25ae7a5 to
6e08788
Compare
|
Is skipping windows f2py CI critical enough that this should wait for #25134? |
As per the existing NumPy situation..
6e08788 to
115c8c6
Compare
|
Should be good to go for now. |
c885c9a to
3f70f78
Compare
|
Thanks @HaoZeke! Changes LGTM; I'm testing this the lazy way to be sure: pushed a commit to trigger wheel builds. |
It's a required test dependency also outside of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All happy, so let's give it a go - thanks Rohit!
Closes #27045, by using the
CompilerCheckerobject to make sure tests which would need a compiler are skipped correctly.TODO
CompilerCheckerbits inf2py-testing.rst.Implementation note
CompilerCheckerbasically runsmeson, so if there are environments where the tests may be run withoutmesonbeing installed at all then this needs to be reworked.Like all the failing Windows buildsIn these scenarios the compiled tests can be skipped anyway.