TST: delete global env_setup fixture #29648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
added
05 - Testing
39 - free-threading
ngoldbaum
changed the title
Member
Probably not, I think we should just try removing it. This was probably added at a time where dict iteration order was undefined, which is a time long gone by. EDIT: Or maybe doctests/very specific tests, but I think then we can deal with it there as we notice issues. |
ngoldbaum
changed the title
Member
|
Well, since all tests pass, let's put it in and see if someone actually notices :). Thanks Nathan! |
18 tasks
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
Sep 10, 2025
delete global env_setup fixture that previously set `PYTHONHASHSEED` presumably for historical reasons (when dict order was random).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #29552. Ping @bwhitt7.
We'd like to use
pytest-run-parallelmore but themonkeypatchfixture gets detected by the plugin as a thread-unsafe fixture.