BUG: fix asarray failure for object dtype with matching leading dimensions#30831
Closed
Sarthak7Gautam wants to merge 1 commit intonumpy:mainfrom
Closed
BUG: fix asarray failure for object dtype with matching leading dimensions#30831Sarthak7Gautam wants to merge 1 commit intonumpy:mainfrom
Sarthak7Gautam wants to merge 1 commit intonumpy:mainfrom
Conversation
…py thought it would be a 3d shape so tried to broadcast it but when 10,9 was encountered as different shapes it failed so transpose to make numpy know that you want to create a 2d array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a
ValueErrorinnp.asarraywhen providing a list of arrays that share a common leading dimension but have different subsequent dimensions whendtype=objectis specified.The Problem
Currently,
np.asarray([a, b], dtype=object)fails ifa.shapeis(10, 10)andb.shapeis(10, 9). NumPy incorrectly attempts to broadcast these into a higher-dimensional array because the first dimensions match, rather than falling back to a 1D object array.Example of the failure: