BUG: fix small issues found with cppcheck#3832
Merged
charris merged 1 commit intonumpy:masterfrom Sep 29, 2013
Merged
Conversation
uninitialized use in _strided_to_strided_one_to_n_with_finish wrong error NULL checks in PyArray_MapIterNew and einsum_sub_op_from_str double free and memleak in umath_linalg.c.src init_@lapack_func@
Member
|
LGTM, thanks. |
charris
added a commit
that referenced
this pull request
Sep 29, 2013
BUG: fix small issues found with cppcheck
Merged
Member
|
Can you think of any tests for these? |
Contributor
Author
|
the strided_to_strided_one_to_n_with_finish should definitely be tested, but I don't know what it does so I have a hard time thinking of a testcase. the other two can probably only be tested by using a malloc that randomly fails. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uninitialized use in strided_to_strided_one_to_n_with_finish
wrong error NULL checks in PyArray_MapIterNew and einsum_sub_op_from_str
double free and memleak in umath_linalg.c.src init@lapack_func@