Skip to content

Remove NUnit.Agent.Core from this repo and use a reference - #1859

Merged
CharliePoole merged 3 commits into
mainfrom
issue-1848
Aug 5, 2026
Merged

Remove NUnit.Agent.Core from this repo and use a reference#1859
CharliePoole merged 3 commits into
mainfrom
issue-1848

Conversation

@CharliePoole

Copy link
Copy Markdown
Member

No description provided.

@manfred-brands manfred-brands left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having to repeat the version, even with the msbuild properties, you could use central package management and only specify the version in Directory.packages.props
See https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management

See also remark on .slnx

Both can be done separately from this PR.

Comment thread NUnitConsole.sln

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be much simpler if migrating to .slnx file.
There is a dotnet sln migrate command for it.

@CharliePoole

Copy link
Copy Markdown
Member Author

@manfred-brands
Thanks for the review. Both of those items are on my radar but, as you say, seem better done separately. I'll add issues for these.

NUnit.Engine.Api and NUnit.Agent.Core use .slnx and I only had to upgrade NuGet to make it work.

Experimenting with central package management a few years ago, I ran into problems with multiple package sources (NU1507 warning). However I see that Terje has made it work without having to use package source mapping, so we should give that a try.

@CharliePoole
CharliePoole merged commit 461f4d1 into main Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants