fix: input listen's output type#18535
Merged
Merged
Conversation
Bahex
added
notes:fixes
nidara-duo
pushed a commit
to nidara-duo/nushell
that referenced
this pull request
Jul 11, 2026
## Description - brought up in: nushell#18528 `input listen` command's signature output type does not match it's actual return value. The command was added in 2bb0c1c, and apparently it's declared signature and actual output never matched. ## User-facing changes (Release notes) - Fixed `input listen`'s output type signature to match actual returned value. With the incorrect signature (and `enforce-runtime-annotations` on) `let x = input listen` would raise an error due to `$x`'s inferred type (based on `input listen`'s signature) not matching the value assigned to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
enforce-runtime-annotations#18528input listencommand's signature output type does not match it's actual return value.The command was added in 2bb0c1c, and apparently it's declared signature and actual output never matched.
User-facing changes (Release notes)
input listen's output type signature to match actual returned value.With the incorrect signature (and
enforce-runtime-annotationson)let x = input listenwould raise an error due to$x's inferred type (based oninput listen's signature) not matching the value assigned to it.