mut and par-each optimizations for performance#18566
Merged
Merged
Conversation
Contributor
|
Using latest nightly with a command like |
Contributor
Author
|
i'll look into it, thanks. |
Contributor
Author
Contributor
|
Works for me👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR has a few changed to increase performance with
par-eachandmutassignments.Two performance optimizations targeting common hot paths in Nushell:
mutfield assignment (cloning reduction viaget_var_mut) andpar-each(thread-pool reuse + captures-only stack clone).I also added a few benchmarks.
User-facing changes (Release notes)
Improved performance of
mutvariable field assignment (e.g.,$list.field = value,$table.0 = value): the variable is now mutated in-place on the evaluation stack instead of being cloned, modified, and stored back. Large list variables see the most benefit — up to 70× faster for 100k-element lists.Improved performance of repeated
par-eachcalls: custom thread pools (--threads N) are cached by thread count and reused, eliminating OS thread spawn overhead on repeated calls. The streaming (unordered) path now only clones the closure's captured variables instead of the entire stack. Combined, these reducepar-eachper-call overhead by up to 33% when callingpar-eachmany times sequentially.Additional notes