Remove all tests that use nu_with_plugins!#18585
Merged
Merged
Conversation
cptpiepmatz
marked this pull request as ready for review
July 12, 2026 22:33
cptpiepmatz
marked this pull request as draft
July 12, 2026 22:37
cptpiepmatz
added
tests
…atz/nushell into no-more-nu_with_plugins
cptpiepmatz
marked this pull request as ready for review
July 13, 2026 18:29
Bahex
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces all usages of
nu_with_plugins!withtest()in combination with#[deps(...)].While working on this, I found that
rstest'stimeoutfeature uses another thread to check for the timeout. This requires a process-wideNuTestersetup instead of a thread local one, so I moved the dependency preparation from being set up as test level to being set up at group level. For that I made the dependencies also part of theGroupKeywhich now creates some more groups than before but this fixes the threading situation.Finally this PR also removes the macro as it is no longer needed and shouldn't be used anyway anymore.
User-facing changes (Release notes)
n/a
Additional notes
cwd,pipeline(), etc. #8670