Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Nutanix driver by adding configurable timeout support and improving error handling for VM lifecycle operations. The changes replace hardcoded timeout values with a user-configurable parameter and add better error handling for edge cases.
Key Changes:
- Added configurable timeout parameter to replace hardcoded 60-iteration loops
- Enhanced error handling in VM removal to handle missing VMs gracefully
- Added cleanup logic to delete VMs that timeout during IP address assignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a configurable timeout for Nutanix operations, improving flexibility and error handling in the
NutanixDriver. The changes include adding a newTimeoutparameter, updating logic to use this parameter, and enhancing error handling during VM creation and deletion processes.Timeout Configuration and Usage:
Timeoutfield to theNutanixDriverstruct and updated theSetConfigFromFlagsmethod to set its value from thenutanix-timeoutflag. The default value is 300 seconds (machine/driver/driver.go, [1] [2] [3].Timeoutvalue divided by 5 seconds (machine/driver/driver.go, [1] [2] [3] [4].Improved Error Handling:
Removemethod to handle cases where the VM ID is empty or the VM is already deleted. Added specific logging for these scenarios (machine/driver/driver.go, [1] [2].machine/driver/driver.go, machine/driver/driver.goL527-R505).Code Cleanup:
machine/driver/driver.go, machine/driver/driver.goL484-R490).