Relation directives with paginator duplicates data with non-unique foreign keys

[mostafa-rz]

Describe the bug

When there is a custom FK in a relation that the FK is not unique, the data will be duplicated. Without a paginator the data is correct.

Expected behavior/Solution

The PaginatedModelsLoader union part, must be optimized.

Steps to reproduce

1. Run testQueryPaginatedHasManyWithNonUniqueForeignKey().

Output/Logs

Click to expand

# Add in log output/error messages here

Lighthouse Version

latest

[spawnia]

Please add a pull request.

[spawnia]

Thanks @mostafa-rz for creating a test case for this. Off the top of my head, I can not think of a way to fix this while preserving the opimizations made by PaginatedModelsLoader.

[mostafa-rz]

If in the loadRelatedModels() the unique values return, the problem will be solved. I think this is enough because later on in associateRelationModels() it is using the match() that just needs the existence of relation not multiple relations for each parent model.

[spawnia]

Thank you, I released your fix in https://github.com/nuwave/lighthouse/releases/tag/v5.68.1.