Merged
Conversation
pyrou
added
enhancement
spawnia
reviewed
Mar 10, 2023
spawnia
reviewed
Mar 10, 2023
Co-authored-by: Benedikt Franke <benedikt@franke.tech>
pyrou
force-pushed
the
multiple-default-guards
branch
from
1a86d27 to
825d4b0
Compare
spawnia
reviewed
Mar 10, 2023
Co-authored-by: Benedikt Franke <benedikt@franke.tech>
pyrou
force-pushed
the
multiple-default-guards
branch
from
e7b4879 to
42651c1
Compare
pyrou
commented
Mar 10, 2023
spawnia
reviewed
Mar 14, 2023
Collaborator
|
Nicely done @pyrou, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When using a query or mutation without
@guarddirective, to allow guest users, only one single default guard was attempted for $context->user. Specifying multiple guards with@guard(with:)allow to attempt multiples guard, but this would disallow guest users.This PR propose to change the
lighthouse.guardconfiguration to support multiple guards.Breaking changes
lighthouse.guardconfiguration key has been renamedlighthouse.guardsand expect now an array.@auth(guard: String)has been changed to@auth(guards: [String!])@whereAuth(guard: String)has been changed to@whereAuth(guards: [String!])