-
Notifications
You must be signed in to change notification settings - Fork 170
Description
What problem does this feature solve?
Thank you for providing a great plugin and module!
Currently the Meta module creates open graph meta tags with a both a name and property-attribute. The presence fo the name-attrib triggers "Warnings That Should Be Fixed" by the Facebook Sharing Debugger:
The following meta tags are specified using 'name' instead of 'property' and will be ignored unless specified using the 'property' key: og:type, og:title, og:site_name, og:description
(my emphasis on "will be ignored")
What does the proposed changes look like?
I suggest removing the name-attribute and go with property only.
I see that the issue has been commented on [before] (#13 (comment)), but the debugger feedback indicates that using the name-key might in fact not be valid. Also the Open Graph protocol specifies the use of property and content attributes for markup, and services like Twitter (which use name and content) documents supporting just property.
Removing ´name´ from og:-tags should have no detrimental effects, but ensure or improve propper parsing from e.g. Facebook.
Sidenote: A similar concern raised elsewhere (at Grav) was concluded by removing the name-attib (though with an unnecessary exception for twitter).
Would a PR for this modification be considered?
Thanks!