fix(docs): remove extra scrollbar in landing hero - #397
Merged
Conversation
overflow-x-hidden on the hero section computed overflow-y to auto and created a nested vertical scrollbar. Use overflow-x-clip on the section and overflow-y-hidden on the code ScrollAreaViewport instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@Axyl1410 is attempting to deploy a commit to the maximogarciamartinez's projects Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overflow-x-hiddenwithoverflow-x-clipon the landing hero section to prevent it from becoming a nested scroll containeroverflow-y-hiddenon the code previewScrollAreaViewportso only horizontal scrolling is enabledContext
overflow-x-hiddencausesoverflow-yto compute toautoper CSS overflow rules. Combined with decorative vertical lines extending past the section height, the hero gained its own vertical scrollbar and caused layout misalignment on the homepage.Screenshots
Test plan