Skip to content

feat(awsAmplify,vercel): make minimumCacheTTL configurable#2278

Open
DamianGlowala wants to merge 1 commit into
mainfrom
feat/minimumCacheTTL
Open

feat(awsAmplify,vercel): make minimumCacheTTL configurable#2278
DamianGlowala wants to merge 1 commit into
mainfrom
feat/minimumCacheTTL

Conversation

@DamianGlowala

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #2271

📚 Description

Allows configuring minimumCacheTTL for AWS Amplify and Vercel providers. Falls back to the default value if not provided.

@DamianGlowala DamianGlowala requested a review from danielroe as a code owner July 11, 2026 11:49
@pkg-pr-new

pkg-pr-new Bot commented Jul 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@2278

commit: c621558

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: c621558
Status: ✅  Deploy successful!
Preview URL: https://bc1c0a82.nuxt-image.pages.dev
Branch Preview URL: https://feat-minimumcachettl.nuxt-image.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 927762bb-4fda-4533-bf85-0a4dfcce99a1

📥 Commits

Reviewing files that changed from the base of the PR and between cb54284 and c621558.

📒 Files selected for processing (5)
  • docs/content/3.providers/aws-amplify.md
  • docs/content/3.providers/vercel.md
  • src/provider.ts
  • src/runtime/providers/awsAmplify.ts
  • src/runtime/providers/vercel.ts

📝 Walkthrough

Walkthrough

Adds typed minimumCacheTTL options for the Vercel and AWS Amplify providers. Provider configuration now propagates the supplied value and retains a 300-second fallback. Documentation for both providers describes the option, default, units, and configuration examples.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: making minimumCacheTTL configurable for AWS Amplify and Vercel.
Description check ✅ Passed The description matches the code changes and accurately states the new configurable minimumCacheTTL behavior with fallback defaults.
Linked Issues check ✅ Passed The PR satisfies the linked issue by adding configurable minimumCacheTTL support for Vercel and AWS Amplify and preserving the default fallback.
Out of Scope Changes check ✅ Passed The added documentation and type updates are directly related to exposing the new minimumCacheTTL option and are not out of scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/minimumCacheTTL

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.61%. Comparing base (458b9ac) to head (c621558).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2278   +/-   ##
=======================================
  Coverage   32.61%   32.61%           
=======================================
  Files           7        7           
  Lines         371      371           
  Branches      131      131           
=======================================
  Hits          121      121           
  Misses        194      194           
  Partials       56       56           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vercel provider hard-codes minimumCacheTTL: 300 with no module option to override

3 participants