feat: move "ipx" into optional dependencies which can be skipped - #380
Closed
PatrickHeneise wants to merge 2 commits into
Closed
feat: move "ipx" into optional dependencies which can be skipped#380PatrickHeneise wants to merge 2 commits into
PatrickHeneise wants to merge 2 commits into
Conversation
pi0
reviewed
Aug 9, 2021
Contributor
Author
|
@pi0 would appreciate a review on this. Running into build issues again on M1. |
Member
|
Hi @PatrickHeneise sorry for the delay and thanks again for helping on this. It is now merged via #403 and will be released shortly as a fix :) BTW some notes:
|
Contributor
Author
|
Thanks @pi0. I didn't know about the "allow editing for maintainers" option, will make sure that's enabled next time. I'm running Node 16. The problems are cross-arch build issues when Docker is involved. I'm not familiar with yarn, but when I move/remove something in the dependencies (which happened here), the lock file needs to be updated, as otherwise it's still installed on production systems with |
Member
|
Indeed when updating dependencies, yarn lock needs to be updated :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
ipxintooptionalDependencies. These can be skipped with--no-optional(npm) or--ignore-optional(yarn) when external image optimization APIs are used (in production systems).sharphas a few install requirements and binaries which can be tricky in some situations.Closes #379