fix(static): guessExt util func return empty string if multiple dots in input - #432
Closed
memotux wants to merge 4 commits into
Closed
fix(static): guessExt util func return empty string if multiple dots in input#432memotux wants to merge 4 commits into
memotux wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
guessExtutility functions not guessing file extension on remote domains with multiple.on URL.That is, with an
inputlike:"https://scontent.cdninstagram.com/v/t51.29350-15/243949415_185792510361274_152802553443058142_n.jpg?_nc_cat=123&ccb=1-5&_nc_sid=123456&_nc_ohc=htMCe123456NxSi&_nc_ht=scontent.cdninstagram.com&edm=AN12345AAA&oe=615123432522"'split' functions not return a valid extension, then
guessExtfunction return an empty string. Then, static provider return a file name like/_nuxt/image/243949415_185792510361274_152802553443058142_n[ext]guessExtfunction was added in commit 58dd744 from PR#340This
guessExtversion is based on getFileExtension function on runtime utils file.Tested with @nuxt/image playground, static files, and remote files.